[webkit-reviews] review denied: [Bug 27959] Support for validationMessage : [Attachment 39107] Patch v1a
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 13 13:19:03 PDT 2009
Adam Barth <abarth at webkit.org> has denied Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 27959: Support for validationMessage
https://bugs.webkit.org/show_bug.cgi?id=27959
Attachment 39107: Patch v1a
https://bugs.webkit.org/attachment.cgi?id=39107&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch seems blocked on not understanding how string localization is
supposed to work. I can't really help with that... I recommend bugging Darin
or Maciej on IRC.
Also, there is a minor style issue:
+ if (customError()) {
+ return m_customErrorMessage;
+ } else if (valueMissing()) {
We're not supposed to use { } for single-line conditionals (applies to this
whole code block).
More information about the webkit-reviews
mailing list