[webkit-reviews] review denied: [Bug 30328] Web Inspector: Migrate profiles to the injected script-based schema. : [Attachment 41095] proposed change

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 30328: Web Inspector: Migrate profiles to the injected script-based schema.
https://bugs.webkit.org/show_bug.cgi?id=30328

Attachment 41095: proposed change
https://bugs.webkit.org/attachment.cgi?id=41095&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
We now are spending twice as much memory for the profile during serialization.
Do you think we could tweak native object a bit so that it we don't need
additional wrapping?

> +	   ScriptFunctionCall function(m_scriptState, m_injectedScriptObj,
"serializeProfile");
> +	   function.appendArgument(toJS(m_scriptState, it->second.get()));
> +	   ScriptValue serializedProfile = function.call();
> +	   m_frontend->didGetProfile(callId, serializedProfile);

Could you extract wrapping into a separate method? (I see two usages).

Otherwise looks good.