[webkit-reviews] review denied: [Bug 24300] Add CSSKeepVisitedLinksPrivate option to WebCore : [Attachment 34405] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 13 12:55:33 PDT 2009
Adam Barth <abarth at webkit.org> has denied robert <robert at roberthogan.net>'s
request for review:
Bug 24300: Add CSSKeepVisitedLinksPrivate option to WebCore
https://bugs.webkit.org/show_bug.cgi?id=24300
Attachment 34405: Updated patch
https://bugs.webkit.org/attachment.cgi?id=34405&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch seems fine, but please add Preference APIs for the other platforms
so we can have better test coverage of this feature. Also m_ignoreVisitedLinks
isn't the greatest name. We're not ignoring visited links. We're ignoring the
history for the purpose of computing the :visited pseud-selector.
More information about the webkit-reviews
mailing list