[webkit-reviews] review granted: [Bug 30337] Web Inspector: Should be able to delete nodes from the Elements Tree : [Attachment 41116] Addresses Tim's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 13 11:55:04 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 30337: Web Inspector: Should be able to delete nodes from the Elements Tree
https://bugs.webkit.org/show_bug.cgi?id=30337

Attachment 41116: Addresses Tim's comments
https://bugs.webkit.org/attachment.cgi?id=41116&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +    if (code != 0)

No need for "!= 0" here.


> +	   var self = this;

Move this line closer to the removeNodeCallback function.


> +	   function removeNodeCallback(removedNodeId) {

Put the brace on the next line.


More information about the webkit-reviews mailing list