[webkit-reviews] review granted: [Bug 29999] [GStreamer] Should handle unknown duration better : [Attachment 40785] patch for duration query, try 2

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has granted Benjamin Otte <otte at gnome.org>'s
request for review:
Bug 29999: [GStreamer] Should handle unknown duration better
https://bugs.webkit.org/show_bug.cgi?id=29999

Attachment 40785: patch for duration query, try 2
https://bugs.webkit.org/attachment.cgi?id=40785&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>

> +    if (!gst_element_query_duration(m_playBin, &timeFormat, &timeLength) ||
> +	   timeFormat != GST_FORMAT_TIME ||
> +	   timeLength == GST_CLOCK_TIME_NONE) {

We don't normally break the expression into multiple lines. I'll fix it up when
landing.

Is it possible to test this or is this covered by our existing tests already?

r=me.