[webkit-reviews] review requested: [Bug 30308] [GStreamer] Add direct support for ARGB videos : [Attachment 41093] 0001-Add-support-for-ARGB-videos.patch

[bugzilla-daemon at webkit.org]

Sebastian Dröge <slomo at circular-chaos.org> has asked  for review:
Bug 30308: [GStreamer] Add direct support for ARGB videos
https://bugs.webkit.org/show_bug.cgi?id=30308

Attachment 41093: 0001-Add-support-for-ARGB-videos.patch
https://bugs.webkit.org/attachment.cgi?id=41093&action=review

------- Additional Comments from Sebastian Dröge <slomo at circular-chaos.org>
New patch that does this, fixes code style at some places and adds some
comments everywhere.
There's also an explanation why I don't use the code from Color.

It's now all done from the streaming thread and not from the main thread, to
only do the necessary bits from the main thread and not block it just because
of the ARGB conversion.

Note: the premultiplication in Color is not optimal IMO, instead of always
rounding upwards it should round to nearest. See also
http://cgit.freedesktop.org/cairo/tree/src/cairo-png.c#n408
My code rounds to nearest too.