[webkit-reviews] review requested: [Bug 29034] ARM compiler does not understand reinterpret_cast<void*> : [Attachment 41086] 2nd try

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 12 22:21:28 PDT 2009


Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 29034: ARM compiler does not understand reinterpret_cast<void*>
https://bugs.webkit.org/show_bug.cgi?id=29034

Attachment 41086: 2nd try
https://bugs.webkit.org/attachment.cgi?id=41086&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Darin, Eric thanks for the feedback.

It seems to me that existing FunctionPtr class in
assembler/MacroAssemblerCodeRef.h could be the single place where we could
special-case for RVCT, instead of sprinkling the C-style casts all over - as
Darin suggested. 

SunSpider reports no change in JIT mode.


More information about the webkit-reviews mailing list