[webkit-reviews] review requested: [Bug 30240] window attributes (like localStorage) that are disabled at runtime are still visible : [Attachment 41081] patch addressing dglazkov's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 12 21:42:37 PDT 2009


Andrew Wilson <atwilson at chromium.org> has asked  for review:
Bug 30240: window attributes (like localStorage) that are disabled at runtime
are still visible
https://bugs.webkit.org/show_bug.cgi?id=30240

Attachment 41081: patch addressing dglazkov's comments
https://bugs.webkit.org/attachment.cgi?id=41081&action=review

------- Additional Comments from Andrew Wilson <atwilson at chromium.org>
OK, updated the whitespace (since GenerateSingleBatchedAttribute needed to
support two different levels of indentation depending on its calling context,
it now takes an indent parameter). The generated file now seems to adhere to
the WebKit style guidelines (at least the parts generated by my new code :).


More information about the webkit-reviews mailing list