[webkit-reviews] review requested: [Bug 30144] MIPS JIT Supports : [Attachment 41075] MIPS JIT Patch 20091012

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 12 17:59:12 PDT 2009


Chao-ying Fu <fu at mips.com> has asked  for review:
Bug 30144: MIPS JIT Supports
https://bugs.webkit.org/show_bug.cgi?id=30144

Attachment 41075: MIPS JIT Patch 20091012
https://bugs.webkit.org/attachment.cgi?id=41075&action=review

------- Additional Comments from Chao-ying Fu <fu at mips.com>
I svn-updated my JavaScriptCore directory and generated a new patch.

Changes in MacroAssemblerMIPS.h:
1. Added unaligned load and branch functions.
2. Fixed LUI to use (offset + 0x8000)>>16 in many places.
3. Used m_isPointer to make sure that two instructions are generated.
4. Used move() functions in all places.

Changes in MIPSAssembler.h:
1. Added lwl, lwr.
2. Fixed relocateJumps() to check pos that has 3 more instructions.

The testing showed new regressions as follows.
	ecma/Date/15.9.5.10-10.js
	ecma/Date/15.9.5.10-2.js
	ecma/Date/15.9.5.10-6.js
	ecma/Date/15.9.5.10-7.js
	ecma/Date/15.9.5.10-8.js
	ecma/Date/15.9.5.10-9.js
	ecma/Date/15.9.5.25-1.js
	ecma/Date/15.9.5.26-1.js
	ecma/Date/15.9.5.28-1.js
	ecma/Date/15.9.5.30-1.js
	ecma/Date/15.9.5.31-1.js
	ecma/Date/15.9.5.34-1.js
	ecma/Date/15.9.5.36-4.js
	ecma/Date/15.9.5.36-5.js
	ecma/Date/15.9.5.36-6.js
	ecma/Date/15.9.5.36-7.js
	ecma/Date/15.9.5.37-4.js
	ecma/Date/15.9.5.37-5.js

I need to debug it later.  Thanks!


More information about the webkit-reviews mailing list