[webkit-reviews] review granted: [Bug 30281] LayoutTests/fast/cookies/local-file-can-set-cookies.html fails when cookies for document already exist : [Attachment 40998] Updated ChangeLog

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jason Yan <tailofthesun at gmail.com>'s
request for review:
Bug 30281: LayoutTests/fast/cookies/local-file-can-set-cookies.html fails when
cookies for document already exist
https://bugs.webkit.org/show_bug.cgi?id=30281

Attachment 40998: Updated ChangeLog
https://bugs.webkit.org/attachment.cgi?id=40998&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is OK, but if we're going to change the test like this I also suggest that
the test do this before setting document.cookie:

    shouldBe("document.cookie.indexOf('ppkcookie1=testcookie')", "-1");

To make sure we are actually setting the cookie. I'll do r=me like this, but
you could consider my suggestion.

I also suggest making per-file comments in change log.