[webkit-reviews] review granted: [Bug 30164] Video keeps playing after going fullscreen, then closing window : [Attachment 41047] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 30164: Video keeps playing after going fullscreen, then closing window
https://bugs.webkit.org/show_bug.cgi?id=30164

Attachment 41047: Patch
https://bugs.webkit.org/attachment.cgi?id=41047&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    QTMovieView *movieView = [[self fullscreenWindow] movieView];
> +    [movieView setMovie:nil];

I would have done this on a single line without a local variable.

I would have included a comment, since it's not obvious that the reason this is
critical is that it stops the movie from playing. Further, the comment could
clarify whether this is a workaround for a QTMovieView bug or if it's simply a
subtle aspect of the design of QTMovieView, as well.