[webkit-reviews] review requested: [Bug 27147] JS Syntax Highlight is incorrect for keyword followed by string or regexp : [Attachment 41019] New Javascript Synax Highlighter

[bugzilla-daemon at webkit.org]

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 27147: JS Syntax Highlight is incorrect for keyword followed by string or
regexp
https://bugs.webkit.org/show_bug.cgi?id=27147

Attachment 41019: New Javascript Synax Highlighter
https://bugs.webkit.org/attachment.cgi?id=41019&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
I'm sorry for the bad patch. 

I have rewritten the syntax highlighter from scratch. 
It now uses similar logic as a proper ECMAScript tokenizer so it should not
confuse DIV and REGEXP anymore.
It also can figure out IDENT tokens(even with Unicode characters too). It's
turned off right now to cut down on the number of elements but maybe we could
use it in the future for the debugger to show variable values.
I also changed it to process 100 tokens at a time. 
It was still beach balling with minified JS so I put a limit on the number of
characters per line it will color.