[webkit-reviews] review requested: [Bug 30242] [XSSAuditor] IFrame JavaScript URLs that are URL-encoded twice can by bypass the XSSAuditor : [Attachment 41015] Patch with test cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 11 20:56:29 PDT 2009


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 30242: [XSSAuditor] IFrame JavaScript URLs that are URL-encoded twice can
by bypass the XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=30242

Attachment 41015: Patch with test cases
https://bugs.webkit.org/attachment.cgi?id=41015&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Here is an updated patch.

I agree the code is getting a bit messy with the booleans. Do you want me to
try to clean this up now? Otherwise, I would suggest we do a clean up patch
after we get this one and bug #27895 resolved.


More information about the webkit-reviews mailing list