[webkit-reviews] review granted: [Bug 30274] HistoryController should point back to FrameLoader not Frame : [Attachment 40988] HistoryController back pointer

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 30274: HistoryController should point back to FrameLoader not Frame
https://bugs.webkit.org/show_bug.cgi?id=30274

Attachment 40988: HistoryController back pointer
https://bugs.webkit.org/attachment.cgi?id=40988&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I think this is OK either way.

Pointing back to the frame is OK because everybody points back to the frame.
It's all one big frame-lifetime-associated family of objects.

Pointing back to the frame loader is OK because the frame loader is the
immediate owner of the history controller, and it's the thing the creates and
destroys the history controller.

I have a hard time getting strong feelings either way.

The part I don't like is functions that are only needed once per page on the
main frame that exist here on a pre-frame object.

r=me, and you can decide whether or not to land this. I really have no
preference.