[webkit-reviews] review requested: [Bug 30281] LayoutTests/fast/cookies/local-file-can-set-cookies-expected.txt fails when cookies for document already exist : [Attachment 40995] patch against r49292
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 10 18:04:04 PDT 2009
Jason Yan <tailofthesun at gmail.com> has asked for review:
Bug 30281: LayoutTests/fast/cookies/local-file-can-set-cookies-expected.txt
fails when cookies for document already exist
https://bugs.webkit.org/show_bug.cgi?id=30281
Attachment 40995: patch against r49292
https://bugs.webkit.org/attachment.cgi?id=40995&action=review
------- Additional Comments from Jason Yan <tailofthesun at gmail.com>
Tested on r49292,
LayoutTests/fast/cookies/local-file-can-set-cookies-expected.txt will fail if
there are other local file cookies already set on the path the test is being
run from. On my machine, the path was "/" and there were other cookies set
already. This results in a failure because the test checks document.cookie to
make sure "ppkcookie1=testcookie" is the only cookie set. The attached patch
changes this to check to use document.cookie.indexOf instead of the equality of
document.cookie.
More information about the webkit-reviews
mailing list