[webkit-reviews] review requested: [Bug 30275] Build fix if Netscape plugin support is turned off : [Attachment 40989] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 10 05:39:20 PDT 2009


Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 30275: Build fix if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=30275

Attachment 40989: proposed patch
https://bugs.webkit.org/attachment.cgi?id=40989&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
In addition to fixing the build break with guards remove notImplemented() from
PluginViewNone.cpp and make them just just be empty functions. The later change
was suggested by Darin in an earlier similar bug (see
https://bugs.webkit.org/show_bug.cgi?id=27940#c5). - As some functions were
already empty in PluginViewNone.cpp, this also makes the PluginViewNone.cpp
more consistent.


More information about the webkit-reviews mailing list