[webkit-reviews] review requested: [Bug 30240] window attributes (like localStorage) that are disabled at runtime are still visible : [Attachment 40973] Added support for EnabledAtRuntime attribute, and set this attr on the DOMWindow.Audio attribute.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 9 16:20:16 PDT 2009


Andrew Wilson <atwilson at chromium.org> has asked  for review:
Bug 30240: window attributes (like localStorage) that are disabled at runtime
are still visible
https://bugs.webkit.org/show_bug.cgi?id=30240

Attachment 40973: Added support for EnabledAtRuntime attribute, and set this
attr on the DOMWindow.Audio attribute.
https://bugs.webkit.org/attachment.cgi?id=40973&action=review

------- Additional Comments from Andrew Wilson <atwilson at chromium.org>
I didn't want to open up the "how to we pull localStorage/etc out of
WebCore::Settings" can of worms in this patch, so I instead used
DOMWindow.Audio as my example, since it has a cleaner, thread-safe, static
interface I can use to determine whether window.Audio should be enabled or not.


More information about the webkit-reviews mailing list