[webkit-reviews] review canceled: [Bug 30240] window attributes (like localStorage) that are disabled at runtime are still visible : [Attachment 40922] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 9 16:18:11 PDT 2009


Andrew Wilson <atwilson at chromium.org> has canceled Andrew Wilson
<atwilson at chromium.org>'s request for review:
Bug 30240: window attributes (like localStorage) that are disabled at runtime
are still visible
https://bugs.webkit.org/show_bug.cgi?id=30240

Attachment 40922: proposed patch
https://bugs.webkit.org/attachment.cgi?id=40922&action=review

------- Additional Comments from Andrew Wilson <atwilson at chromium.org>
As requested, pulled the refactoring of GenerateBatchedAttributeData into two
functions into its own patch, to make the whole patch simpler to review.
Tragically, diff is still confused by this patch, so it's not obvious that 95%
of this is just a whitespace change caused by changing the indentation level.


More information about the webkit-reviews mailing list