[webkit-reviews] review granted: [Bug 5863] feMorphology filter is not implemented : [Attachment 40956] feMorphologyElement

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 5863: feMorphology filter is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5863

Attachment 40956: feMorphologyElement
https://bugs.webkit.org/attachment.cgi?id=40956&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Wonderful patch, r=me.

Some small style issues:

> +SVGFEMorphologyElement::SVGFEMorphologyElement(const QualifiedName& tagName,
Document* doc)
> +    : SVGFilterPrimitiveStandardAttributes(tagName, doc)

Use "document" instead of "doc", old legacy code uses abbrevations here.
> +    interface [Conditional=SVG&FILTERS, GenerateConstructor]
SVGFEMorphologyElement : SVGElement,
> +							    
SVGFilterPrimitiveStandardAttributes {
Please line up SVGElement & SVGFilterPrimitiveStandardAttributes.

> -	   PassRefPtr<FEMorphology> create(FilterEffect*,
MorphologyOperatorType, const float&, const float&);  
> +	   static PassRefPtr<FEMorphology> create(FilterEffect*,
MorphologyOperatorType, float, float);	
Please specify parameter names for the floats.

> -	   FEMorphology(FilterEffect*, MorphologyOperatorType, const float&,
const float&);
> +	   FEMorphology(FilterEffect*, MorphologyOperatorType, float, float);
Ditto.

Please fix before landing.