[webkit-reviews] review requested: [Bug 30186] Optimization: Many StringImpl transformations are no-ops and should just return 'this' : [Attachment 40953] patch 3

[bugzilla-daemon at webkit.org]

Jens Alfke <snej at chromium.org> has asked  for review:
Bug 30186: Optimization: Many StringImpl transformations are no-ops and should
just return 'this'
https://bugs.webkit.org/show_bug.cgi?id=30186

Attachment 40953: patch 3
https://bugs.webkit.org/attachment.cgi?id=40953&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
Fixed the issues that were pointed out.
Fixing the bug in simplifyWhiteSpace required adding a test inside the
space-skipping loop. I don't think it'll slow it down much, and in my testing I
found that this method isn't called much, and all of the calls I did see were
no-ops; so I think it's still worthwhile.