[webkit-reviews] review denied: [Bug 30213] [Qt] Avoid ErrorPageExtensionOption to hold empty 'url' field : [Attachment 40875] patch 0.1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 9 07:36:54 PDT 2009


Simon Hausmann <hausmann at webkit.org> has denied Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>'s request for review:
Bug 30213: [Qt] Avoid ErrorPageExtensionOption to hold empty 'url' field
https://bugs.webkit.org/show_bug.cgi?id=30213

Attachment 40875: patch 0.1
https://bugs.webkit.org/attachment.cgi?id=40875&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

> -	   QUrl url = m_reply->url();
> +	   QUrl url = (m_reply->url().toString().isNull()) ? m_request.url():
m_reply->url();

Instead of converting the url to a QString first before checking if it's null,
can you call isEmpty() on QUrl instead?

I.e.

QUrl url = m_reply->url();
if (url.isEmpty())
    url = m_request.url();


Is there any way to write a unit test for this? :)


More information about the webkit-reviews mailing list