[webkit-reviews] review requested: [Bug 30240] window attributes (like localStorage) that are disabled at runtime are still visible : [Attachment 40922] proposed patch

[bugzilla-daemon at webkit.org]

Andrew Wilson <atwilson at chromium.org> has asked  for review:
Bug 30240: window attributes (like localStorage) that are disabled at runtime
are still visible
https://bugs.webkit.org/show_bug.cgi?id=30240

Attachment 40922: proposed patch
https://bugs.webkit.org/attachment.cgi?id=40922&action=review

------- Additional Comments from Andrew Wilson <atwilson at chromium.org>
This just contains a single example of how to disable an attribute at runtime
(using localStorage).

If this approach is acceptable, we can follow up with a second patch to address
the other runtime-enabled APIs.

The changes to CodeGeneratorV8.pm are not as large as they appear - I
refactored the guts of GenerateBatchedAttributeData into
GenerateSingleBatchedAttribute, which necessitated changing the indentation
level, which confused the heck out of diff. But I did not make any significant
changes to that code.