[webkit-reviews] review denied: [Bug 30234] Win: Double clicking words in selects adjacent newlines : [Attachment 40915] Fixes issue where doubleclicking a word could select following adjacent newlines.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 30234: Win: Double clicking words in selects adjacent newlines
https://bugs.webkit.org/show_bug.cgi?id=30234

Attachment 40915: Fixes issue where doubleclicking a word could select
following adjacent newlines.
https://bugs.webkit.org/attachment.cgi?id=40915&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I'm not so happy with this function being named isSpace(). The <ctype.h>
function named isspace() returns true for newlines, and having such a
similarly-named function with different behavior seems wrong. So if you do want
to add a function I think it needs a different name.

It's also worth noting that the characters coming out of the CharacterIterator
will not be '\r' characters under any circumstance. I think for this patch it
would be better to just add a special case for '\n' in the VisibleSelection
code rather than adding the new function.

This otherwise seems fine.