[webkit-reviews] review canceled: [Bug 18994] LANG/LC_ALL influences the result of element.style.opacity : [Attachment 40916] use dtoa directly in CSS units

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 8 15:32:27 PDT 2009


Evan Martin <evan at chromium.org> has canceled Evan Martin <evan at chromium.org>'s
request for review:
Bug 18994: LANG/LC_ALL influences the result of element.style.opacity
https://bugs.webkit.org/show_bug.cgi?id=18994

Attachment 40916: use dtoa directly in CSS units
https://bugs.webkit.org/attachment.cgi?id=40916&action=review

------- Additional Comments from Evan Martin <evan at chromium.org>
This is my current plan.  Only four tests fail after this patch: all of them
are due to the %fs in the matrix printing.

The size-reservation code is a bit silly; I wonder if it'd be better to just
always reserve 8 characters (the expected number + decimal point + sign) and
have CSS where the values are obscene (like 20 digits long) cause us to
realloc.


More information about the webkit-reviews mailing list