[webkit-reviews] review requested: [Bug 30141] Make AtomicString construct StringImpls in single malloc blocks : [Attachment 40900] patch 2

[bugzilla-daemon at webkit.org]

Jens Alfke <snej at chromium.org> has asked  for review:
Bug 30141: Make AtomicString construct StringImpls in single malloc blocks
https://bugs.webkit.org/show_bug.cgi?id=30141

Attachment 40900: patch 2
https://bugs.webkit.org/attachment.cgi?id=40900&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
- Made setHash private, since it only needs to be called by the friend
XXXTranslator classes.
- Added whitespace in setHash definition.
- Added explanatory comment about the StringImpl ctor.

After investigating I decided against Darin's suggestion of customized create
methods, because it introduced more code, including passing a hash parameter
through several layers of method calls, which I think cancels out any win from
only initializing the member once. (See my previous comment.)