[webkit-reviews] review granted: [Bug 30223] [LayoutTests][Gtk] Set a common Gtk theme as default and update the results : [Attachment 40894] Set Raleigh as the default theme

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 8 12:06:05 PDT 2009


Eric Seidel <eric at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 30223: [LayoutTests][Gtk] Set a common Gtk theme as default and update the
results
https://bugs.webkit.org/show_bug.cgi?id=30223

Attachment 40894: Set Raleigh as the default theme
https://bugs.webkit.org/attachment.cgi?id=40894&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Sounds fine to me.  Seems silly to wrap this line when lines just below it have
no wrapping.  WebKit style has no official column width.

Also WebKit style is to use 0 instead of NULL for c++ code, although maybe the
gtk code follows some other style?  check-webkit-style should help identify
some style issues.

looks fine, but cq- for the style oddities.


More information about the webkit-reviews mailing list