[webkit-reviews] review denied: [Bug 30220] [GTK] middle-click-onpaste.html test does not work : [Attachment 40893] Added bug URL to the Changelog

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Alejandro Garcia Castro
<alex at igalia.com>'s request for review:
Bug 30220: [GTK] middle-click-onpaste.html test does not work
https://bugs.webkit.org/show_bug.cgi?id=30220

Attachment 40893: Added bug URL to the Changelog
https://bugs.webkit.org/attachment.cgi?id=40893&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Personally I don't find g_return_val_if_fail very readable.

if (!exception || !*exception)
    return JSValueMakeUndefined(context);
is the same number of characters, split over 2 lines, and much more readable to
those of us who don't hack on gtk normally. :)

Also, I think that this should just assert(!exception) instead.  The testing
tool is allowed to fail hard in cases like this.