[webkit-reviews] review denied: [Bug 30216] [Qt] better handle possible edge cases on qwebframe::requestedUrl use : [Attachment 40880] patch 0.1 - make use or error.failingURL as much as possible

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 8 11:09:37 PDT 2009


Eric Seidel <eric at webkit.org> has denied Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>'s request for review:
Bug 30216: [Qt] better handle possible edge cases on qwebframe::requestedUrl
use
https://bugs.webkit.org/show_bug.cgi?id=30216

Attachment 40880: patch 0.1 - make use or error.failingURL as much as possible
https://bugs.webkit.org/attachment.cgi?id=40880&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The ChagneLog doesn't say what this does.

What edge cases?  What is the modification to that if and why?

Why do we need to clear the previous error.  Comments should ideally be
sentences, beginning with a capital and ending with a period.


More information about the webkit-reviews mailing list