[webkit-reviews] review denied: [Bug 30200] Move executeScript from FrameLoader to ScriptController : [Attachment 40857] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 8 09:32:29 PDT 2009


Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 30200: Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200

Attachment 40857: Patch v1
https://bugs.webkit.org/attachment.cgi?id=40857&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Can you first invent a x-platform ScriptController if your'e going to add
duplicate code?

ScriptController

And then ScriptControllerJSC and ScriptControllerV8 which inherit from it?

Or heck, you don't even need them to inherit.  Just add a new
ScriptController.cpp at the root level which has these fixes, and makes sure
both builds include it, no?

Unless this code is not copy/paste and I'm mising something?

r- for adding copy/paste code.


More information about the webkit-reviews mailing list