[webkit-reviews] review requested: [Bug 30211] [Qt] Consider prefering QImage* over QPixmap* as NativeImagePtr : [Attachment 40870] Proposed change to change NativeImagePtr to QImage and method to cache certain images as QPixmap

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 8 07:48:05 PDT 2009


Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 30211: [Qt] Consider prefering QImage* over QPixmap* as NativeImagePtr
https://bugs.webkit.org/show_bug.cgi?id=30211

Attachment 40870: Proposed change to change NativeImagePtr to QImage and method
to cache certain images as QPixmap
https://bugs.webkit.org/attachment.cgi?id=40870&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
If measurements show that this patch is faster I would heavily encourage to use
it. For now I'm seeking for review, advice and ideas on how to fill the
findScaledOrCreatePixmap with content. I'm searching for criteria where we
would like to create a QPixmap for performance reasons and assume we have
access to CachedImage as well.


More information about the webkit-reviews mailing list