[webkit-reviews] review requested: [Bug 30209] Cache::m_liveDecodedResource is not sorted by CachedResource::m_lastDecodedAccessTime : [Attachment 40868] Update m_lastDecodedAccessTime in CachedResource::setDecodedSize
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 8 07:32:23 PDT 2009
Holger Freyther <zecke at selfish.org> has asked for review:
Bug 30209: Cache::m_liveDecodedResource is not sorted by
CachedResource::m_lastDecodedAccessTime
https://bugs.webkit.org/show_bug.cgi?id=30209
Attachment 40868: Update m_lastDecodedAccessTime in
CachedResource::setDecodedSize
https://bugs.webkit.org/attachment.cgi?id=40868&action=review
------- Additional Comments from Holger Freyther <zecke at selfish.org>
Update the m_lastDecodedAccessTime when we insert the resource. The code in
CachedImage is checking the FrameView painting time but the CachedResource is
not doing this when using WTF::currentTime so I decided to not do it.
I just recognized that this has a problem with the CachedImage::didDraw code...
as this is using FrameView time which is before ::currentTime(). So
CachedResource::setDecodedSize should use the FrameView time as well.
I'm posting this patch anyway to get feedback on the issue and the proposed
resolution.
More information about the webkit-reviews
mailing list