[webkit-reviews] review requested: [Bug 30188] REGRESSION(r49203): Text Drag and Drop stopped working in latest nightly build : [Attachment 40843] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 30188: REGRESSION(r49203): Text Drag and Drop stopped working in latest
nightly build
https://bugs.webkit.org/show_bug.cgi?id=30188

Attachment 40843: Patch
https://bugs.webkit.org/attachment.cgi?id=40843&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
I know I may be given some grief in that I am treating the DragOperation enum
as an unsigned. We should fix this because such operations are needed and done
on variables of type DragOperation in other parts of the drag-and-drop code.
The solution would be to follow a similar approach as in AppKit's NSDragging.h,
that is typedef DragOperation as an unsigned and define an anonymous enum of
DragOperations.

I suggest deferring this fix for a separate bug.

Also, this patch does not include a test case because since this issue is
observed when dragging data inside the web browser to an external application a
DRT test is not possible. Moreover, a non-trivial manual test case is not
possible for the same reason.