[webkit-reviews] review denied: [Bug 29529] MathML Support for mover, munder, munderover, msubsup, and mfrac : [Attachment 40262] Updated patch containing tweaks to use MathMLNames for tag/attribute names

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Alex Milowski <alex at milowski.com>'s
request for review:
Bug 29529: MathML Support for mover, munder, munderover, msubsup, and mfrac
https://bugs.webkit.org/show_bug.cgi?id=29529

Attachment 40262: Updated patch containing tweaks to use MathMLNames for
tag/attribute names
https://bugs.webkit.org/attachment.cgi?id=40262&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
There is a pretty big conceptual mistake in this code, and it involves the
handling of attributes.  You can't simply query for attributes in methods like
addChild and just do a one-time fetch, since you basically have destroyed all
dynamism by doing so.  You need to be more like HTML/SVG, which either map
attributes to style (using the MappedAttribute concept in parseMappedAttribute
and mapToEnty), or dirty in some way such that the renderer can regrab relevant
info from the element (see various updateFromElement methods).