[webkit-reviews] review denied: [Bug 30174] Web Inspector: Wrap Database into ScriptObject in v8 bindings. : [Attachment 40801] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 7 11:39:46 PDT 2009
Adam Barth <abarth at webkit.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 30174: Web Inspector: Wrap Database into ScriptObject in v8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=30174
Attachment 40801: patch
https://bugs.webkit.org/attachment.cgi?id=40801&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Test?
+ Frame* frame = database->document()->frame();
This line has a tab.
What if frame() is null?
+ // FIXME: What if context.IsEmpty()?
You need to handle this case!
+ ScriptState* scriptState =
frame->page()->inspectorController()->frontendScriptState();
What if page() is null?
More information about the webkit-reviews
mailing list