[webkit-reviews] review denied: [Bug 30154] Allow custom memory allocation control for JavaScriptCore's SharedSymbolTable : [Attachment 40767] proposed patch

[bugzilla-daemon at webkit.org]

Zoltan Horvath <zoltan at webkit.org> has denied  review:
Bug 30154: Allow custom memory allocation control for JavaScriptCore's
SharedSymbolTable
https://bugs.webkit.org/show_bug.cgi?id=30154

Attachment 40767: proposed patch
https://bugs.webkit.org/attachment.cgi?id=40767&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
> Index: JavaScriptCore/ChangeLog
> ===================================================================
> --- JavaScriptCore/ChangeLog	(revision 49225)
> +++ JavaScriptCore/ChangeLog	(working copy)
> @@ -1,3 +1,15 @@
> +2009-10-07  Zoltan Horvath  <zoltan at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Allow custom memory allocation control for JavaScriptCore's
SharedSymbolTable
> +	   https://bugs.webkit.org/show_bug.cgi?id=30154
> +
> +	   Inherits SharedSymbolTable struct from FastAllocBase because it
> +	   has been instantiated by 'new' in
JavaScriptCore/bytecode/CodeBlock.h:621.
> +
> +	   * runtime/SymbolTable.h:
> +
>  2009-10-06  Priit Laes  <plaes at plaes.org>
>  
>	   Reviewed by Gavin Barraclough.
> Index: JavaScriptCore/runtime/SymbolTable.h
> ===================================================================
> --- JavaScriptCore/runtime/SymbolTable.h	(revision 49225)
> +++ JavaScriptCore/runtime/SymbolTable.h	(working copy)
> @@ -41,7 +41,7 @@ namespace JSC {
>      // reasonably small positive or negative number, and therefore has its
high
>      // four bits all set or all unset.
>  
> -    struct SymbolTableEntry {
> +    struct SymbolTableEntry : FastAllocBase {
>	   SymbolTableEntry()
>	       : m_bits(0)
>	   {