[webkit-reviews] review denied: [Bug 30118] [Qt] QWebPage autotest crash: createViewlessPlugin : [Attachment 40772] fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 7 07:53:55 PDT 2009


Simon Hausmann <hausmann at webkit.org> has denied jedrzej.nowacki at nokia.com's
request for review:
Bug 30118: [Qt] QWebPage autotest crash: createViewlessPlugin
https://bugs.webkit.org/show_bug.cgi?id=30118

Attachment 40772: fix
https://bugs.webkit.org/attachment.cgi?id=40772&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
As discussed in the office, the current code doesn't _actually_ leak as the
WebCore::Widget subclasses for QWidget and QGraphicsWidget delete the objects
in their destructor.

However what is missing in the current code is a null pointer check if
page->d->client is a null pointer.


More information about the webkit-reviews mailing list