[webkit-reviews] review requested: [Bug 30121] [GTK] Segfault while testing fast/events/keydown-keypress-preventDefault.html : [Attachment 40769] Fix for this issue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 7 01:08:55 PDT 2009


Martin Robinson <martin.james.robinson at gmail.com> has asked  for review:
Bug 30121: [GTK] Segfault while testing
fast/events/keydown-keypress-preventDefault.html
https://bugs.webkit.org/show_bug.cgi?id=30121

Attachment 40769: Fix for this issue
https://bugs.webkit.org/attachment.cgi?id=40769&action=review

------- Additional Comments from Martin Robinson
<martin.james.robinson at gmail.com>
In this case it appears as though preventDefault() was preventing the creation
of a keypress events. Preedit and completed composition data is processed
during keypress events. Thus, in this test, the unused data was still lingering
during the next keydown event. The attached patch handles this situation by
first clearing the previous data, if any exists during keydown events.


More information about the webkit-reviews mailing list