[webkit-reviews] review canceled: [Bug 18994] LANG/LC_ALL influences the result of element.style.opacity : [Attachment 40753] start patching out CSS floats with a Vector<UChar>

[bugzilla-daemon at webkit.org]

Evan Martin <evan at chromium.org> has canceled Evan Martin <evan at chromium.org>'s
request for review:
Bug 18994: LANG/LC_ALL influences the result of element.style.opacity
https://bugs.webkit.org/show_bug.cgi?id=18994

Attachment 40753: start patching out CSS floats with a Vector<UChar>
https://bugs.webkit.org/attachment.cgi?id=40753&action=review

------- Additional Comments from Evan Martin <evan at chromium.org>
Hey Darin,

Could you take a glance at this and see if it's in the direction of where you
were suggesting Alp go?  Obviously I'd need to relocate these functions to the
appropriate places.

Note that dtoa works with chars so we need to do a conversion step when we use
it, so appending a letter at a time to the uchar vector doesn't seem so
horrible.

However, the matrix line that I highlighted in the patch probably does call for
some sort of builder class.  I looked at the existing classes you mentioned but
it's not clear to me what the right thing to do is.