[webkit-reviews] review granted: [Bug 22878] It should be possible to post (clone) built-in JS objects to Workers : [Attachment 40699] It should be possible to post (clone) built-in JS objects to Workers

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 22878: It should be possible to post (clone) built-in JS objects to Workers
https://bugs.webkit.org/show_bug.cgi?id=22878

Attachment 40699: It should be possible to post (clone) built-in JS objects to
Workers
https://bugs.webkit.org/attachment.cgi?id=40699&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
In the test case, I'd suggest renaming 'equal' to something more descriptive (I
initially wondered, "why not just use ==" :-) ).  Maybe 'isCloneOf'?

In SerializedArray, all index values should be less than 'm_length'.

In SerializedScriptValueData, I think 'operator bool ()' should be 'operator
bool()' – a quick grep of JSC would seem to agree with this.

r+