[webkit-reviews] review canceled: [Bug 29178] Geolocation should be refactored to use a single map to store all notifiers : [Attachment 40716] Patch 2 for Bug 29178

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has canceled Steve Block
<steveblock at google.com>'s request for review:
Bug 29178: Geolocation should be refactored to use a single map to store all
notifiers
https://bugs.webkit.org/show_bug.cgi?id=29178

Attachment 40716: Patch 2 for Bug 29178
https://bugs.webkit.org/attachment.cgi?id=40716&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
(In reply to comment #10)
> Complicate in a good way. In my opinion, the current logic is unnecessarily
> subtle. It's the kind of cleverness that hurts maintainability over time. It
> would be easy to just add additional code in clearOneShots and not rely in
that
> fact.
OK, I've updated the logic to use positive IDs for both one-shots and watchers.
On wrap-around, we simply overwrite the previous request, to maintain the
current behaviour.