[webkit-reviews] review requested: [Bug 28054] use derefInNotNull function to work around winscw compiler bug regarding template arguments. : [Attachment 40736] include PassRefPtr.h explicitly to avoid possible building break.

[bugzilla-daemon at webkit.org]

Yongjun Zhang <yongjun.zhang at nokia.com> has asked  for review:
Bug 28054: use derefInNotNull function to work around winscw compiler bug
regarding template arguments.
https://bugs.webkit.org/show_bug.cgi?id=28054

Attachment 40736: include PassRefPtr.h explicitly to avoid possible building
break.
https://bugs.webkit.org/attachment.cgi?id=40736&action=review

------- Additional Comments from Yongjun Zhang <yongjun.zhang at nokia.com>
Mark and Eric, thank you both for the comments.

I copied the idea from adoptRef<T>() in PassRefPtr.h when introducing
derefIfNotNull(); and I assume if adoptRef doesn't break the build, neither
will derefIfNotNull().

To be safe, I modified the patch and explicitly include PassRefPtr.h to prevent
possible building break.

Regarding the concern on performance hit, the patch only removes inline for
winscw compiler; for other compilers, derefIfNotNull is still inlined.