[webkit-reviews] review denied: [Bug 29910] Load state can get out of sync in a client callback, leading to a crash. : [Attachment 40724] Updated the patch after latest changes to frameLoader.cpp

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yael <yael.aharon at nokia.com>'s request
for review:
Bug 29910: Load state can get out of sync in a client callback, leading to a
crash.
https://bugs.webkit.org/show_bug.cgi?id=29910

Attachment 40724: Updated the patch after latest changes to frameLoader.cpp
https://bugs.webkit.org/attachment.cgi?id=40724&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Even if this change is simple, we need to make sure we never have this bug
again.

Best would be to have a layout test.  If you really believe a layout test is
impossible, you need to explain so in the ChangeLog.  Explain why it's
impossible, and what would reproduce this if it were possible.	A
WebCore/manual-test is an option, but less desirable.

Additionally, you could/should	add a comment next to the
setState(FrameStateComplete), to explain why it needs to be set before
progressCompleted is called.

the loader is subtle.  We need to make it less subtle. :)  Your help in doing
so is most appreciated!