[webkit-reviews] review granted: [Bug 30131] Make beforeload work with script elements : [Attachment 40727] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 30131: Make beforeload work with script elements
https://bugs.webkit.org/show_bug.cgi?id=30131

Attachment 40727: Patch
https://bugs.webkit.org/attachment.cgi?id=40727&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +++ WebCore/dom/ScriptElement.h	(working copy)
> @@ -44,9 +44,10 @@ public:
>      virtual String languageAttributeValue() const = 0;
>      virtual String forAttributeValue() const = 0;
>  
> +    virtual bool dispatchBeforeLoadEvent(const String& sourceURL) = 0;
>      virtual void dispatchLoadEvent() = 0;
>      virtual void dispatchErrorEvent() = 0;
> -
> +    

Unneeded whitespace change here.

I think you could share the dispatchBeforeLoadEvent implementation by making it
a static protected helper function on ScriptElement.

r=me