[webkit-reviews] review granted: [Bug 28091] ApplyStyleCommand removes presentational tags even when not necessary : [Attachment 38971] new patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 6 09:42:13 PDT 2009
Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 28091: ApplyStyleCommand removes presentational tags even when not
necessary
https://bugs.webkit.org/show_bug.cgi?id=28091
Attachment 38971: new patch
https://bugs.webkit.org/attachment.cgi?id=38971&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
In general this looks good.
CSSDecorationAddedByTag should be "cssDecorationAddedByTag"
And here:
65 bool shouldRemoveTextDecorationTag(CSSStyleDeclaration* styleToApply,
int CSSDecorationAddedByTag) const;
You could have used locals to store "nextElement" instead of casting
nextSibling twice. But it's also OK as is.
LGTM.
More information about the webkit-reviews
mailing list