[webkit-reviews] review requested: [Bug 30128] [v8] fix crbug/671: XPathEvaluator.evalute() will throw "NAMESPACE_ERR: DOM Exception 14" when applied to XML with namespaces : [Attachment 40718] First pass

[bugzilla-daemon at webkit.org]

anton muhin <antonm at chromium.org> has asked  for review:
Bug 30128: [v8] fix crbug/671: XPathEvaluator.evalute() will throw
"NAMESPACE_ERR: DOM Exception 14" when applied to XML with namespaces
https://bugs.webkit.org/show_bug.cgi?id=30128

Attachment 40718: First pass
https://bugs.webkit.org/attachment.cgi?id=40718&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
I am somewhat concerned how that complicates the logic of CodeGeneratorV8.pm. 
Another option I considered was to make necessary methods custom and provide
hand-written implementation.  However, that won't fix other methods that might
have the same problem, e.g., originally I only fixed Document.createExpression,
but fix propagated to XPathEvaluator.evaluate automatically.  On the other
hand, maybe we should decide for exceptions on case by case basis.  The last
thing that convinced me not to go with custom methods was Safari---they have
this special logic for all XPathEvaluators.

And another note.  I added new layout tests into existing .html, but if it's
against the rules (e.g. we'd like to emphasize that those tests verify contra
standard behaviour), I'd be glad to lift them into a separate file.