[webkit-reviews] review requested: [Bug 28141] SVG Filter feGaussianBlur implementation is missing : [Attachment 40713] feGaussianBlur implementation

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has asked  for review:
Bug 28141: SVG Filter feGaussianBlur implementation is missing
https://bugs.webkit.org/show_bug.cgi?id=28141

Attachment 40713: feGaussianBlur implementation
https://bugs.webkit.org/attachment.cgi?id=40713&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
I changed the double conversion to unsigned char. And fixed the writing of
blur(r)ing :-). I also missed an early return, if one dimension of the kernel
has the size of 0.

You were right with the overflow. There is a overflow on filling the kernel if
the kernel size is bigger than the width/height of the effect. I double checked
the rest of the code and didn't see further problems. I calculated some
examples manualy (e.g. A kernel with 3x3) and it works as expected. An overflow
on the blurring itself seems to me impossible, since I check if the next or
previous value is not catched if it isn't in the current row/column (between 0
and width/height of a column/row).

I compared many other examples with FF and Opera and did not see any
differences.