[webkit-reviews] review denied: [Bug 20081] [Qt] Add support for windowless NPAPI plugins : [Attachment 40627] Patch 3/4 - Add PluginQuirkUsesScreenDefaultVisual for Flash.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Girish Ramakrishnan
<girish at forwardbias.in>'s request for review:
Bug 20081: [Qt] Add support for windowless NPAPI plugins
https://bugs.webkit.org/show_bug.cgi?id=20081

Attachment 40627: Patch 3/4 - Add PluginQuirkUsesScreenDefaultVisual for Flash.
https://bugs.webkit.org/attachment.cgi?id=40627&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
There are a few coding style issues left and one detail:

> +
> +	   No new tests. (OOPS!)

Please remove this line :)



> +				      ((NPSetWindowCallbackStruct
*)m_npWindow.ws_info)->depth);

Coding style :)
  

> +    const int drawableDepth = ((NPSetWindowCallbackStruct
*)m_npWindow.ws_info)->depth;

Same here.


> +#ifndef QT_NO_XRENDER
> +    static const bool useXrender = qgetenv("QT_X11_NO_XRENDER").isNull(); //
Should also check for XRender >= 0.5
> +#else
> +    static const bool useXrender = false;
> +#endif

Kenneth suggested on chat that this should perhaps be useXRender?