[webkit-reviews] review denied: [Bug 29832] Crash in DOMWindow::clearTimeout etc when DOMWindow is not connected to frame : [Attachment 40644] Proposed fix.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 5 23:32:07 PDT 2009
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 29832: Crash in DOMWindow::clearTimeout etc when DOMWindow is not connected
to frame
https://bugs.webkit.org/show_bug.cgi?id=29832
Attachment 40644: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=40644&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> + Reviewed by NOBODY (OOPS!).
> +
> + Crash Crash in DOMWindow::clearTimeout etc when DOMWindow is not
connected to frame.
extra "Crash"
> + https://bugs.webkit.org/show_bug.cgi?id=29832
> +
> + Need to make sure the script caches are reset when frame gets
disconnected from still-alive DOMWindow.
> + This will prevent JS from calling DOMWindow methods that can
not be completed w/o the frame.
oops ^^^ tabs need to be changed to spaces
More information about the webkit-reviews
mailing list