[webkit-reviews] review denied: [Bug 28141] SVG Filter feGaussianBlur implementation is missing : [Attachment 40597] feGaussianBlur implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 5 23:01:28 PDT 2009
Oliver Hunt <oliver at apple.com> has denied Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 28141: SVG Filter feGaussianBlur implementation is missing
https://bugs.webkit.org/show_bug.cgi?id=28141
Attachment 40597: feGaussianBlur implementation
https://bugs.webkit.org/attachment.cgi?id=40597&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
There are a few places where blurring is misspelled as bluring.
double(sum / dx) seems bogus -- both sum and dx are integer types, so you're
just doing an integer divide and casting to double, which is either
superfluous, or not what you intended to do.
What happens if i apply this filter to a 3x3 image? it looks to me like
there's potential for overflow...
More information about the webkit-reviews
mailing list