[webkit-reviews] review denied: [Bug 29841] Add WebSocket addEventListener and removeEventListener : [Attachment 40691] JavaScript bindings of WebSocket addEventListener/removeEventListener

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Fumitoshi Ukai <ukai at chromium.org>'s
request for review:
Bug 29841: Add WebSocket addEventListener and removeEventListener
https://bugs.webkit.org/show_bug.cgi?id=29841

Attachment 40691: JavaScript bindings of WebSocket
addEventListener/removeEventListener
https://bugs.webkit.org/attachment.cgi?id=40691&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> -	   // [Custom] void addEventListener(in DOMString type,
> -	   //	in EventListener listener,
> -	   //	in boolean useCapture);
> -	   // [Custom] void removeEventListener(in DOMString type,
> -	   //	in EventListener listener,
> -	   //	in boolean useCapture);
> -	   // boolean dispatchEvent(in Event evt)
> -	   //	raises(EventException);
> +	   [Custom] void addEventListener(in DOMString type,
> +	      in EventListener listener,
> +	      in boolean useCapture);
> +	   [Custom] void removeEventListener(in DOMString type,
> +	      in EventListener listener,
> +	      in boolean useCapture);
> +	    boolean dispatchEvent(in Event evt)
> +	      raises(EventException);

The indentation here is quite odd.

This needs tests, so r-.